Completes initial design and refactor of dynamic configuration #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this a commit in a separate branch for me to experinment implementing dynamic discovery of the api endpoints, at the moment because of import cycles the singleton seems to be overrwritten REFS #5
we have the discovery object being initialised when the base class initialises and then the discovery fetches the url, note that the href that the discover will return are fully qualified addresses this drops using the api_base prefix post this we need to formalies the configuration and syntax so this scales to all endpoints we are also yet to test for unlicensed features REFS #5
adds context around the design of the classes and lifecycle for dynamic discovery of api endpoints REFS #5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the majority of #5 still pending from the work is:
The remainder of the work to be conducted in the
dto-implementationbranch