synchronize: add delay_updates option #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminvakil
changed the title
quidame
reviewed
Apr 25, 2021
quidame
approved these changes
Apr 26, 2021
|
Thanks Amin and quidame! |
Akasurde
reviewed
May 27, 2021
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
|
Rerun CI. |
|
Rerun CI. |
Akasurde
added
the
gate
|
@aminvakil Thanks for the contribution, |
felixfontein
reviewed
Jun 1, 2021
| @@ -464,6 +473,9 @@ def main(): | |||
| ) | |||
| _sshpass_pipe = os.pipe() | |||
| cmd = ['sshpass', '-d' + to_native(_sshpass_pipe[0], errors='surrogate_or_strict')] + cmd | |||
| if delay_updates: | |||
| cmd.append('--delay_updates') | |||
There was a problem hiding this comment.
This breaks the module: it crashes with rsync: --delay_updates: unknown option\nrsync error: syntax or usage error (code 1) at main.c(1746)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #157
ISSUE TYPE
COMPONENT NAME
synchronize
ADDITIONAL INFORMATION
This does not disable the
delay-updatesby default, so current behaviour will not be changed, but adds an option which can be set to false and disabledelay-updates.