Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix REJECT target name #215

Merged
merged 5 commits into from
Jul 14, 2021
Merged

fix REJECT target name #215

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
757b544
fix REJECT target name
e-hur Jun 29, 2021
fcb2a46
add fragment
Jun 29, 2021
310c68e
add tests for REJECT target
Jun 29, 2021
0492926
fix yaml syntax for reject choices
Jun 29, 2021
c596fea
Review comments
Akasurde Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/modules/firewalld.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
description:
- firewalld Zone target
- If state is set to C(absent), this will reset the target to default
choices: [ default, ACCEPT, DROP, REJECT ]
choices: [ default, ACCEPT, DROP, %%REJECT%% ]
Akasurde marked this conversation as resolved.
Show resolved Hide resolved
type: str
version_added: 1.2.0
notes:
Expand Down Expand Up @@ -748,7 +748,7 @@ def main():
interface=dict(type='str'),
masquerade=dict(type='str'),
offline=dict(type='bool'),
target=dict(type='str', choices=['default', 'ACCEPT', 'DROP', 'REJECT']),
target=dict(type='str', choices=['default', 'ACCEPT', 'DROP', '%%REJECT%%']),
Akasurde marked this conversation as resolved.
Show resolved Hide resolved
Akasurde marked this conversation as resolved.
Show resolved Hide resolved
),
supports_check_mode=True,
required_by=dict(
Expand Down