Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the handling of exclusive options #297

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Refine the handling of exclusive options #297

merged 1 commit into from
Nov 29, 2021

Conversation

saito-hideki
Copy link
Collaborator

SUMMARY

Refine the handling of exclusive options using mutually_exclusive:

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • ansible.posix.firewalld
ADDITIONAL INFORMATION

None

- Fixes #255

Signed-off-by: Hideki Saito <saito@fgrep.org>
@saito-hideki saito-hideki marked this pull request as ready for review November 29, 2021 13:24
@saito-hideki
Copy link
Collaborator Author

saito-hideki commented Nov 29, 2021

@Akasurde @Andersson007 @maxamillion @gundalow I would appreciate it if you guys could review this PR! :)

@maxamillion maxamillion added the gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate") label Nov 29, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxamillion
Copy link
Collaborator

@saito-hideki thank you for the PR, this contribution is greatly appreciated!

@ansible-zuul ansible-zuul bot merged commit a8fcc02 into ansible-collections:main Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate")
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message is missing target and port_forward parameters
2 participants