Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace distutils with included module in ansible-core 2.12 to address PEP 632 #304

Merged
merged 3 commits into from
Jan 7, 2022
Merged

Replace distutils with included module in ansible-core 2.12 to address PEP 632 #304

merged 3 commits into from
Jan 7, 2022

Conversation

saito-hideki
Copy link
Collaborator

SUMMARY

Replace distutils.* with included module in ansible-core 2.12 to addresss PEP 632 if available.
It does not change the behavior of ansible-core 2.11 or earlier.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • plugins/module_utils/firewalld.py
    • plugins/modules/firewalld_info.py
ADDITIONAL INFORMATION

None

@saito-hideki saito-hideki marked this pull request as ready for review December 23, 2021 06:13
@saito-hideki
Copy link
Collaborator Author

@Akasurde @Andersson007 @gundalow @maxamillion
Hi guys,
I would appreciate it if you guys could review this PR :)

@saito-hideki saito-hideki changed the title Replace distutils with included module in ansible-core 2.12 to address PEP 632 [WIP] Replace distutils with included module in ansible-core 2.12 to address PEP 632 Dec 23, 2021
felixfontein
felixfontein reviewed Dec 23, 2021
View reviewed changes
changelogs/fragments/304_pep632.yml Outdated Show resolved Hide resolved
plugins/module_utils/version.py Outdated Show resolved Hide resolved
@saito-hideki saito-hideki changed the title [WIP] Replace distutils with included module in ansible-core 2.12 to address PEP 632 Replace distutils with included module in ansible-core 2.12 to address PEP 632 Dec 24, 2021
@saito-hideki
Copy link
Collaborator Author

@Andersson007 @felixfontein thank you for the review! I have fixed my PR based on change requests.
If it is possible, could you review this again?

@felixfontein felixfontein mentioned this pull request Dec 28, 2021
Merged
@felixfontein
Copy link
Contributor

Please consider integrating ansible-collections/community.general#3984 into this PR.

@saito-hideki saito-hideki changed the title Replace distutils with included module in ansible-core 2.12 to address PEP 632 [WIP] Replace distutils with included module in ansible-core 2.12 to address PEP 632 Jan 6, 2022
@saito-hideki @Akasurde
Replace distutils with included module in ansible-core 2.12
a45448b 
- Fixes #303
- Addresses PEP 632(https://www.python.org/dev/peps/pep-0632/)

Signed-off-by: Hideki Saito <saito@fgrep.org>
@saito-hideki saito-hideki changed the title [WIP] Replace distutils with included module in ansible-core 2.12 to address PEP 632 Replace distutils with included module in ansible-core 2.12 to address PEP 632 Jan 6, 2022
felixfontein
felixfontein reviewed Jan 6, 2022
View reviewed changes
changelogs/fragments/304_pep632.yml Outdated Show resolved Hide resolved
plugins/module_utils/version.py Outdated Show resolved Hide resolved
Akasurde and others added 2 commits January 6, 2022 20:50
@Akasurde @felixfontein
Apply suggestions from code review
44a23e3 
Co-authored-by: Felix Fontein <felix@fontein.de>
@saito-hideki
Added loading StrictVersion to helper module
90cdaf8 
Signed-off-by: Hideki Saito <saito@fgrep.org>
@saito-hideki
Copy link
Collaborator Author

@Akasurde @Andersson007 @felixfontein Guys, thank you for your valuable advice and changes on this PR!
If there are no problems with this PR, I'm going to ship it to the gate :)

@saito-hideki saito-hideki self-assigned this Jan 7, 2022
@saito-hideki saito-hideki added the gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate") label Jan 7, 2022
ansible-zuul[bot]
ansible-zuul bot approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 3acced9 into ansible-collections:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

@ansible-zuul Ansible Zuul ansible-zuul approved these changes

@Andersson007 Andersson007 Awaiting requested review from Andersson007

Assignees

@saito-hideki saito-hideki

Labels
gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate")
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to replace distutils.* in ansible.posix to address PEP 632
4 participants
@saito-hideki @felixfontein @Andersson007 @Akasurde