Improve error handling in support code for cryptography backend

[felixfontein]

SUMMARY

If a ValueError is raised, convert it to a OpenSSLObjectError instead of letting the caller code crash on the unexpected exception type.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

plugins/module_utils/crypto/support.py

[Andersson007]

You didn't change the logic, only added raising a better type of error, did you?
If the logic was changed, are the related code parts covered by tests?

[felixfontein]

The logic should not change at all, there's only one more try/except in load_certificate and load_certificate_request, which converts ValueErrors raised by cryptography to OpenSSLObjectError's.

(In load_privatekey, the IOError/OSError catch now only covers the part which actually reads the file. It's not needed for the rest.)

[Andersson007]

the GH representation looks a bit messy in this case, ok:)
LGTM

[felixfontein]

It does indeed! I mostly unindented a whole block, but the diff just looks horrible ;)

[felixfontein]

@Andersson007 thanks for reviewing this!