Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acme_certificate: error when requested challenge type is not found for non-valid challenges instead of hanging #173

Merged
merged 2 commits into from
Jan 17, 2021
Merged

acme_certificate: error when requested challenge type is not found for non-valid challenges instead of hanging #173

merged 2 commits into from
Jan 17, 2021

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Fixes #171.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

acme_certificate

This was referenced Jan 16, 2021
Closed
Closed
@felixfontein
Copy link
Contributor Author

CC @resmo

resmo
resmo approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit d43998f into ansible-collections:main Jan 17, 2021
@felixfontein felixfontein deleted the acme_certificate-wrong-challenge branch January 17, 2021 11:17
@felixfontein
Copy link
Contributor Author

@resmo thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

acme_certificate challenge completion (step 2) hangs
2 participants
@felixfontein @resmo