Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl_csr_info and x509_certificate_info: return more public key information #233

Merged
merged 6 commits into from
May 19, 2021
Merged

openssl_csr_info and x509_certificate_info: return more public key information #233

merged 6 commits into from
May 19, 2021

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Returns the information of openssl_publickey_info for the public key in openssl_csr_info and x509_certificate_info.

Fixes #227.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

openssl_csr_info
x509_certificate_info

@felixfontein felixfontein mentioned this pull request May 18, 2021
Closed
Ajpantuso
Ajpantuso requested changes May 18, 2021
View reviewed changes
Copy link
Collaborator

@Ajpantuso Ajpantuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the public key fingerprints can be retrieved from get_publickey_info and the reference to get_fingerprint_of_bytes can be removed from csr_info.py. Otherwise just a documentation question.

plugins/module_utils/crypto/module_backends/certificate_info.py Outdated Show resolved Hide resolved
plugins/module_utils/crypto/module_backends/csr_info.py Outdated Show resolved Hide resolved
plugins/modules/openssl_csr_info.py Outdated Show resolved Hide resolved
@felixfontein felixfontein mentioned this pull request May 19, 2021
Closed
11 tasks
Ajpantuso
Ajpantuso approved these changes May 19, 2021
View reviewed changes
Copy link
Collaborator

@Ajpantuso Ajpantuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@felixfontein felixfontein merged commit 0a0d0f2 into ansible-collections:main May 19, 2021
@felixfontein felixfontein deleted the public-key-info branch May 19, 2021 12:02
@felixfontein
Copy link
Contributor Author

@Ajpantuso and again, thanks for reviewing this one :)

@renovate renovate bot mentioned this pull request Aug 25, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ajpantuso Ajpantuso Ajpantuso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openssl_csr_info - add key size if possible
2 participants
@felixfontein @Ajpantuso