Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid crash in check mode #243

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Avoid crash in check mode #243

merged 3 commits into from
Jun 2, 2021

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Do not let AnsibleModule crash when setting permissions on not yet existing files in check mode.

Fixes #242.

This is related to ansible/ansible#64279.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

various modules

@felixfontein felixfontein mentioned this pull request Jun 2, 2021
Closed
@felixfontein felixfontein mentioned this pull request Jun 2, 2021
Closed
11 tasks
Ajpantuso
Ajpantuso approved these changes Jun 2, 2021
View reviewed changes
Copy link
Collaborator

@Ajpantuso Ajpantuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@felixfontein felixfontein merged commit 376d7cd into ansible-collections:main Jun 2, 2021
@felixfontein felixfontein deleted the mode-set-nonexistant branch June 2, 2021 14:44
@felixfontein
Copy link
Contributor Author

@Ajpantuso thanks a lot for reviewing!

@renovate renovate bot mentioned this pull request Aug 25, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ajpantuso Ajpantuso Ajpantuso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openssl_privkey fails in check mode
2 participants
@felixfontein @Ajpantuso