openssh_keypair - Add diff support and general cleanup #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ajpantuso
changed the title
…ng CentOS6 restrictions
Ajpantuso
force-pushed
the
openssh_keypair_cleanup
branch
from
ba5f34c
to
8cf4026
Compare
|
Please note that ansible-test's recently updated pylint reports some failures for this PR. |
Addressed with the latest commit. |
Done, I had also moved around some method definitions to make the classes more readable, but no functional changes in the last two commits. |
felixfontein
approved these changes
Aug 18, 2021
|
@Ajpantuso thanks a lot for implementing this! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds
diffsupport foropenssh_keypairas well as enhances file overwriting operations to preserve and restore from backup in the event of failure. Also integrates both of theopenssh_*modules to ensure consistency.ISSUE TYPE
COMPONENT NAME
plugins/modules/openssh_cert.py
plugins/modules/openssh_keypair.py
ADDITIONAL INFORMATION
Fixes some issues for file permissions as well:
ssh-keygenpreserves the original files permissions when overwriting and these changes ensure thecryptographybackend does the same.atomic_moveis replaced withpreserved_copywhen no file exists at the destination to prevent a potentially secure file from being updated with permissions from the parent directory's mask.