Support cryptography 35.0.0 for the openssl_pkcs12 module #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
force-pushed
the
fix-cryptography-pkcs12
branch
from
3046d89
to
ab26c4d
Compare
felixfontein
force-pushed
the
fix-cryptography-pkcs12
branch
from
ab26c4d
to
aa2fcb7
Compare
felixfontein
changed the title
|
ready_for_review |
This was referenced Oct 3, 2021
|
@Ajpantuso thanks for reviewing this! |
Backport to stable-1: 💚 backport PR created✅ Backport PR branch: Backported as #299 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 3, 2021
(cherry picked from commit d6c0d53)
felixfontein
added a commit
that referenced
this pull request
Oct 3, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow-up to #294,
which right now includes #294. Will rebase once #294 is merged.Fixes #293.
Due to the friendly name being stored as the 'alias' of the X.509 cert, which isn't supported by cryptography's Rust code, we need to re-parse the PKCS#12 and extract the friendly name from the OpenSSL X.509 object directly. Once pyca/cryptography#6348 or something similar lands in cryptography we can get rid of this crutch...
ISSUE TYPE
COMPONENT NAME
openssl_pkcs12