openssl_privatekey_info: disable private key consistency checks by default #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ajpantuso
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
LGTM, only comment is to maybe include a link in the description of check_consistency describing the theoretical risk of computing with private key material (this is the first I found that's not a scholarly article https://access.redhat.com/blogs/766093/posts/1976303). That might avoid unnecessary concerns around the breaking change.
|
I've extended the description to mention side-channel attacks. |
|
@Ajpantuso thanks for reviewing this! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This adds an option
check_consistencyto allow users to explicitly request private key consistency checks (currently supported for some key types, but not all). This is a breaking change since in < 2.0.0, these checks were always made. I think it's better to disable them by default so that key material is not unnecessarily copied into Python data structures, and no computations are done with it (which could in theory result in timing attacks).(This also affects diff mode for openssl_privatekey and openssl_privatekey_pipe.)
ISSUE TYPE
COMPONENT NAME
openssl_privatekey_info