Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme error reporting: allow type to be missing in problem documents #652

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Fixes #651.

According to https://www.rfc-editor.org/rfc/rfc7807#section-3.1, type can be not present in problem documnts (https://www.rfc-editor.org/rfc/rfc8555#section-6.7). So don't assume it is always there. ZeroSSL apparently sometimes returns errors without it (#651).

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

acme module utils

Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and simple:)

@felixfontein felixfontein merged commit 526b3c4 into ansible-collections:main Aug 21, 2023
128 checks passed
@felixfontein felixfontein deleted the acme branch August 21, 2023 18:49
@felixfontein
Copy link
Contributor Author

@Andersson007 thanks a lot for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'type' when processing challenge error response.
2 participants