Add cipher and hash options to luks_create #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
reviewed
Aug 4, 2020
There was a problem hiding this comment.
The behavior of only using the new values on creation is ok, that's also what is currently done for keysize. There are some minor details I noticed, I added comments for them.
In any case, you need a changelog fragment (category minor_changes).
|
CC @mulatinho you might also be interested in this. |
Closed
|
@Arnoways thanks a lot for contributing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Pull request to Add the "cipher" and "hash" option to luks_create, allowing the user to specify the encryption they want.
ISSUE TYPE
COMPONENT NAME
luks_device
ADDITIONAL INFORMATION
These options will only be used at LUKS container creation, since they are coming from luksFormat in cryptsetup.
I refered to the manpage to write the documentation, I hope it will fit into the module.
First PR here, I'm obviously open to critics, suggestions etc... 😃