Skip to content

Commit

Permalink
Also fix docker_api connection plugin.
Browse files Browse the repository at this point in the history
  • Loading branch information
felixfontein committed Nov 22, 2021
1 parent c1bc830 commit f7bb702
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelogs/fragments/243-docker_container_exec-chdir.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
bugfixes:
- "docker_container_exec - ``chdir`` is only supported since Docker SDK for Python 3.0.0. Make sure that this option can only use when 3.0.0 or later is installed, and prevent passing this parameter on when ``chdir`` is not provided to this module (https://github.com/ansible-collections/community.docker/pull/243, https://github.com/ansible-collections/community.docker/issues/242)."
- "docker_api connection plugin - avoid passing an unnecessary argument to a Docker SDK for Python call that is only supported by version 3.0.0 or later (https://github.com/ansible-collections/community.docker/pull/243)."
2 changes: 1 addition & 1 deletion plugins/connection/docker_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def exec_command(self, cmd, in_data=None, sudoable=False):
stderr=True,
stdin=need_stdin,
user=self._play_context.remote_user or '',
workdir=None,
# workdir=None, - only works for Docker SDK for Python 3.0.0 and later
))
exec_id = exec_data['Id']

Expand Down

0 comments on commit f7bb702

Please sign in to comment.