docker_image: allow to tag images by name, improve docs #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminvakil
reviewed
Jun 4, 2021
| format I(repository:tag). If no tag is provided, will use the value of the C(tag) parameter or I(latest). | ||
| - Use with state C(present) to tag the image. | ||
| - Expects format C(repository:tag). If no tag is provided, will use the value of the I(tag) parameter or C(latest). | ||
| - If I(push=true), I(repository) must either include a registry, or will be assumed to belong to the default |
There was a problem hiding this comment.
I may misunderstood what you have meant by including a registry though.
Suggested change
| - If I(push=true), I(repository) must either include a registry, or will be assumed to belong to the default | |
| - If I(push=true), I(repository) must either be a registry, or will be assumed to belong to the default |
There was a problem hiding this comment.
A registry is "your.registry.com:5000", a name including a registry is "your.registry.com:5000/repo/image". I mean the latter here.
There was a problem hiding this comment.
Ah, sure, thanks for clarification.
felixfontein
changed the title
felixfontein
changed the title
|
Ok, this is no longer a docs PR, but a feature + docs PR. It allows to tag images by ID, which didn't work before because it tried to add |
|
ready_for_review |
briantist
approved these changes
Jun 7, 2021
|
@aminvakil @briantist thanks a lot for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #147.
Also adds explicit tests which tag a docker image by ID.
ISSUE TYPE
COMPONENT NAME
docker_image