[PR #249/d224752c backport][stable-1] Minor fixes to nsenter connection plugin #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* Minor fixes to nsenter connection plugin - Ensure the nsoption_pid option is retrieved in _connect instead of __init__ to prevent a crasher due to initialization order - Replace the use of --all-namespaces with specific namespaces to support compatibility with Busybox nsenter (for example, Alpine) * minor tidy * Fix PEP8 violation * Changelog fragment * Update changelogs/fragments/249-nsenter-fixes.yml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Jeff Goldschrafe <jeff.goldschrafe@flatiron.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit d224752)
felixfontein
deleted the
patchback/backports/stable-1/d224752cf1957c64af4962671b357922293a141c/pr-249
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #249 as merged into main (d224752).
SUMMARY
Two fixes to the nsenter connection plugin:
nsenter_pidoption is retrieved in_connectinstead of__init__to prevent a crasher due to bad initialization order--all-namespaceswith specific namespaces to support compatibility with Busybox nsenter (used on for example, Alpine containers)ISSUE TYPE
COMPONENT NAME
nsenter connection plugin
ADDITIONAL INFORMATION
N/A