Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_swarm: adds data_path_addr option for swarm init and swarm join #344

Merged
merged 6 commits into from
May 9, 2022
Merged

docker_swarm: adds data_path_addr option for swarm init and swarm join #344

merged 6 commits into from
May 9, 2022

Conversation

chrische
Copy link
Contributor

@chrische chrische commented May 2, 2022

SUMMARY

Allows usage of data_path_addr parameter while initializing or joining a swarm. See also #339.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

docker_swarm

ADDITIONAL INFORMATION
- name: Execute docker init
  community.docker.docker_swarm:
    state: present
    advertise_addr: ens11
    listen_addr: ens11
    data_path_addr: ens10

@github-actions
Copy link

github-actions bot commented May 2, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@chrische chrische mentioned this pull request May 2, 2022
Open
@felixfontein felixfontein added enhancement New feature or request docker-swarm Docker Swarm labels May 2, 2022
felixfontein
felixfontein reviewed May 2, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added a first few comments.

changelogs/fragments/344-adds-data-path-addr.yml Outdated Show resolved Hide resolved
plugins/modules/docker_swarm.py Show resolved Hide resolved
plugins/modules/docker_swarm.py Outdated Show resolved Hide resolved
@felixfontein felixfontein changed the title adds data_path_addr option for swarm init and swarm join. docker_swarm: adds data_path_addr option for swarm init and swarm join May 2, 2022
chrische and others added 3 commits May 3, 2022 11:01
@chrische @felixfontein
adds formatting to changelog entry
3c6e2d8 
Co-authored-by: Felix Fontein <felix@fontein.de>
@chrische @felixfontein
adds version to doc entry in ansible_swarm
c910c05 
Co-authored-by: Felix Fontein <felix@fontein.de>
@chrische @felixfontein
rewrites doc entry to formal language
9a627f4 
Co-authored-by: Felix Fontein <felix@fontein.de>
@chrische @felixfontein
Correct docker api version (src: docker api docs)
384d88d 
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein
Copy link
Collaborator

Will merge in a couple of days so others also have a chance to take a look.

@felixfontein felixfontein merged commit 98b2270 into ansible-collections:main May 9, 2022
@felixfontein
Copy link
Collaborator

@chrische thanks for contributing this!

@felixfontein felixfontein mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
docker-swarm Docker Swarm enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrische @felixfontein