Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker-compose from python dependencies #360

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion galaxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace: community
name: docker
version: 2.6.0
version: 3.0.0-alpha.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be removed from this PR. Release-related changes are not part of regular PRs.

readme: README.md
authors:
- Ansible Docker Working Group
Expand Down
3 changes: 2 additions & 1 deletion meta/ee-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
docker
docker-compose
# do not add docker-compose python package as a depedency as the module
# is unmaintained and it is now a go project and called by docker directly.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a) a changelog fragment, and b) a second PR with a deprecation changelog fragment (to be merged and released soon). This one can only be merged once we start preparing 3.0.0 (which isn't planned right now at all).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meanwhile I removed this collection from creator-ee.