docker_plugin: do not crash when plugin doesn't exist #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
approved these changes
Jan 12, 2023
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
|
Re-triggering tests after 0142910 was added to |
|
@briantist thanks for reviewing this! |
felixfontein
added a commit
to felixfontein/community.docker
that referenced
this pull request
Jan 13, 2023
…tions#553) * Do not crash when plugin doesn't exist. * Improve style. Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com> Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com> (cherry picked from commit c7cbec0)
felixfontein
added a commit
that referenced
this pull request
Jan 13, 2023
* Do not crash when plugin doesn't exist. * Improve style. Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com> Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com> (cherry picked from commit c7cbec0)
felixfontein
added a commit
that referenced
this pull request
Jan 14, 2023
…557) * Do not crash when plugin doesn't exist. * Improve style. Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com> Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com> (cherry picked from commit c7cbec0) (cherry picked from commit 0ffa3cc) Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #552.
ISSUE TYPE
COMPONENT NAME
docker_plugin