Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_container: add default_host_ip option #71

Merged

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #70.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

docker_container

@felixfontein
Copy link
Collaborator Author

@seblu if you have time, feel free to test this :) I tested it locally with Docker CE 20.10.2, and for my simple test case it worked.

@seblu
Copy link

seblu commented Jan 19, 2021

Yes, this will make my ansible collection fu be better ! I needed to learn how to overrides collection.

So, it looks like it works as expected.

TASK [community.docker.docker_container] *****************************************************************************************************************************************************
task path: /home/seblu/scm/infra/playbooks/test.yml:6
--- before
+++ after
@@ -2,11 +2,7 @@
     "expected_ports": {
         "25826/udp": [
             {
-                "HostIp": "::",
-                "HostPort": "25826"
-            },
-            {
-                "HostIp": "0.0.0.0",
+                "HostIp": "",
                 "HostPort": "25826"
             }
         ]

@felixfontein
Copy link
Collaborator Author

@WojciechowskiPiotr can you take a quick look? If we can get this merged and a new version released by next ~Tuesday, this should get included in the next Ansible 2.10.6 release (which will probably be the last 2.10.x release).

@WojciechowskiPiotr
Copy link
Collaborator

@WojciechowskiPiotr can you take a quick look? If we can get this merged and a new version released by next ~Tuesday, this should get included in the next Ansible 2.10.6 release (which will probably be the last 2.10.x release).

@WojciechowskiPiotr WojciechowskiPiotr merged commit 6adb148 into ansible-collections:main Jan 20, 2021
@WojciechowskiPiotr
Copy link
Collaborator

WojciechowskiPiotr commented Jan 20, 2021

Merged, closed by accident, sorry.

Shouldn't we include this option in examples? I mean this is quite a significant change that needs to be made in playbooks when migrating to 20.10 so maybe some example(s) should help the users to not make mistakes? I know they should read the documentation, but still...

@felixfontein felixfontein deleted the default-ip branch January 21, 2021 06:47
@felixfontein
Copy link
Collaborator Author

@WojciechowskiPiotr makes sense. Feel free to create a PR for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPv6 port mapping broken with docker 20.10.2
3 participants