-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module docker_plugin #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for picking up the docker_plugin module! I've added a few first comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following changes are needed to make check mode work correctly.
Check mode should be mostly identical to the real plugin behavior, except that the actual Docker SDK for Python calls are not done. Everything else - reporting changes, reporting actions - should be done as if check mode is not enabled.
(Sorry, that was one too much. I deleted it, you might need to reload so that it actually vanishes for you.) |
If you want to run the integration tests manually: (This requires that you checked out the repository so that Ansible can use it, see https://docs.ansible.com/ansible/devel/dev_guide/developing_collections.html#contributing-to-collections for details.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've found two details in the tests, but besides that I think it's ready (as much as I can judge):
Fixed! @felixfontein Thanks for the Review. |
@porshkevich thanks for contributing the first version of this module! |
SUMMARY
This module introduces docker plugin features. User can perform the following task with this module:
1- Create/Remove a Plugin
2- Enable/Disable the Plugin
3- Change the settings of a plugin
TODO
1- Functionality to upgrade the plugin
2- Add Integration test for plugin-options.
Fixes #74
ISSUE TYPE
COMPONENT NAME
docker_plugin
ADDITIONAL INFORMATION
This module was already started in 2019 ansible/ansible#52643
Docker SDK is used from here https://docker-py.readthedocs.io/en/stable/plugins.html