Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfs_quota: use project name when setting a new project to a mount #3350

Closed
wants to merge 1 commit into from

Conversation

rytis
Copy link

@rytis rytis commented Sep 8, 2021

SUMMARY

When setting new project to a mount point project name has to be supplied in the command. This was missing and therefore adding new project never worked.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.general.xfs_quota

ADDITIONAL INFORMATION

To reproduce:

Check that there are no quotas set:

xfs_quota -x -c 'df -h'

Try enabling quota on mounted XFS filesystem

ansible -m xfs_quota -a 'type=project name=varlog mountpoint=/var'

Then check again, and observe that no project quota flag is set.

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug community_review module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review stale_ci CI is older than 7 days, rerun before merging system labels Sep 8, 2021
@Ajpantuso
Copy link
Collaborator

Thanks for your contribution! Please add a changelog fragment when you are able. Also note that this change appears to have broken the integration tests. Please review the following portion of the integration tests to assess whether the original assumption that re-application of project limits should report a change was correct.

@felixfontein felixfontein added backport-2 check-before-release PR will be looked at again shortly before release and merged if possible. labels Sep 10, 2021
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_triage needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI stale_ci CI is older than 7 days, rerun before merging labels Sep 10, 2021
@felixfontein felixfontein changed the title Use project name when setting a new project to a mount xfs_quota: use project name when setting a new project to a mount Sep 14, 2021
@felixfontein
Copy link
Collaborator

@rytis could you please reply to @Ajpantuso's comment? Thanks.

needs_info

@ansibullbot ansibullbot added needs_info This issue requires further information. Please answer any outstanding questions stale_ci CI is older than 7 days, rerun before merging labels Sep 16, 2021
@russoz
Copy link
Collaborator

russoz commented Oct 8, 2021

hi @rytis are you still working on this PR? Could you please address the comment from @Ajpantuso ? Thanks for your contribution! :-)

@ansibullbot
Copy link
Collaborator

@rytis This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

@ansibullbot
Copy link
Collaborator

@rytis You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information.

click here for bot help

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review module module needs_info This issue requires further information. Please answer any outstanding questions needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review stale_ci CI is older than 7 days, rerun before merging system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants