Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pfexec become usable for illumos #3889

Merged
merged 8 commits into from
Oct 5, 2022
Merged

Make pfexec become usable for illumos #3889

merged 8 commits into from
Oct 5, 2022

Conversation

manschwetusCF
Copy link
Contributor

@manschwetusCF manschwetusCF commented Dec 11, 2021 •
edited
Loading

SUMMARY

Pfexec become does not work for illumos
fixes #3671

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/become/pfexec.py

ADDITIONAL INFORMATION

Changed quoting and command composition in analogy to standard su become

@ansibullbot

This comment has been minimized.

Sign in to view
@ansibullbot
Copy link
Collaborator

cc @None
click here for bot help

@ansibullbot ansibullbot added become become plugin needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review bug This issue/PR relates to a bug and removed needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly small_patch Hopefully easy to review labels Dec 11, 2021
@ansibullbot

This comment has been minimized.

Sign in to view
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Dec 11, 2021
@ansibullbot ansibullbot added tests tests unit tests/unit labels Dec 11, 2021
@ansibullbot

This comment has been minimized.

Sign in to view
@felixfontein felixfontein added backport-3 check-before-release PR will be looked at again shortly before release and merged if possible. labels Dec 11, 2021
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Dec 12, 2021
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Dec 20, 2021
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed stale_ci CI is older than 7 days, rerun before merging labels Sep 12, 2022
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Sep 20, 2022
felixfontein
felixfontein reviewed Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a changelog fragment? Then I can merge this.

This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akasurde Akasurde Akasurde left review comments

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
become become plugin bug This issue/PR relates to a bug needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pfexec become plugin does not work on illumos distros
5 participants
@manschwetusCF @ansibullbot @manschwetus @felixfontein @Akasurde