[PR #4557/29c49feb backport][stable-4] Add 'state' parameter for alternatives #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* Add 'activate' parameter for alternatives Allow alternatives to be installed without being set as the current selection. * add changelog fragment * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> * rename 'activate' -> 'selected' * rework 'selected' parameter -> 'state' * handle unsetting of currently selected alternative * add integration tests for 'state' parameter * fix linting issues * fix for Python 2.7 compatibility * Remove alternatives file. Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 29c49fe)
ansibullbot
added
backport
feature
felixfontein
deleted the
patchback/backports/stable-4/29c49febd9fa726748b9f6771b77746c67d0028c/pr-4557
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #4557 as merged into main (29c49fe).
Allow alternatives to be installed without being set as the current selection. Fixes #4543.
SUMMARY
Adds a
stateparameter to the alternatives module with the following behavior:selected, the module behaves exactly as at present:present, the alternative will be installed, but not set as the current selection for the group.selectedand is now set topresent, the group will be set to use auto mode.This change preserves existing behavior by default and allows the following behavior if
stateis set topresent:ISSUE TYPE
COMPONENT NAME
alternatives
ADDITIONAL INFORMATION
There is an example in the description of #4543.
A few questions:
Any better ideas for parameter names thanUpdate: changed toactivate?state.selected = Falsethe default behavior? At present, the PR preserves the existing default behavior, but to me it does not seem very useful.