Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gconftool2: deprecate state get #4778

Merged
merged 4 commits into from
Jul 29, 2022
Merged

gconftool2: deprecate state get #4778

merged 4 commits into from
Jul 29, 2022

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jun 4, 2022

SUMMARY

Deprecates state=get in favour of using module gconftool2_info.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/system/gconftool2.py

@ansibullbot
Copy link
Collaborator

cc @Akasurde @kevensen
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) system labels Jun 4, 2022
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 and removed backport-5 labels Jun 5, 2022
@felixfontein
Copy link
Collaborator

Since the new module has just been added, it's better to wait with the deprecation until much later in the 5.x.0 release cycle, or even just do it in 6.0.0. (The removal version should probably be 8.0.0 then.)

I'm currently tending to do the deprecation in 6.0.0 and the removal in 8.0.0, because then we can already merge this PR into main (without backporting it) and forget about it until 8.0.0 comes around ;-)

@russoz
Copy link
Collaborator Author

russoz commented Jun 5, 2022

okie, makes sense

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jun 13, 2022
@felixfontein
Copy link
Collaborator

Can you adjust the deprecation? Then we can merge it to main without backporting it.

@russoz
Copy link
Collaborator Author

russoz commented Jul 29, 2022

Can you adjust the deprecation? Then we can merge it to main without backporting it.

Forgot about this ticket for a while. Just done that.

@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Jul 29, 2022
@github-actions
Copy link

github-actions bot commented Jul 29, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 29, 2022
@felixfontein felixfontein merged commit f544aac into ansible-collections:main Jul 29, 2022
@felixfontein
Copy link
Collaborator

@russoz thanks for doing this!

@russoz russoz deleted the gconftool2-deprecate-state-get branch July 29, 2022 21:01
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@russoz
gconftool2: deprecate state get (ansible-collections#4778)
b049131 
* gconftool2: deprecate state get

* added changelog fragment

* Update plugins/modules/system/gconftool2.py

* Update plugins/modules/system/gconftool2.py
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@russoz
gconftool2: deprecate state get (ansible-collections#4778)
aaef313 
* gconftool2: deprecate state get

* added changelog fragment

* Update plugins/modules/system/gconftool2.py

* Update plugins/modules/system/gconftool2.py
@trux-bot trux-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module plugins plugin (any type) system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein