proxmox inventory: fix for agent enabled

[planeturban]

SUMMARY

Some (newer?) instances of proxmox uses "enabled=1" instead of just "1" in the agent config line. This fix adds ´agent_enabled´, checks if the first field is int; if so, set it to value. If not check if string equals "enabled=1" to set it ´agent_enabled´ to 1. Without this fix the inventory would be empty.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

community.general.proxmox

ADDITIONAL INFORMATION

[ansibullbot]

cc @Ajpantuso @Thulium-Drake @ilijamt @joshainglis @karmab @tleguern
click here for bot help

[planeturban]

After looking soberly at the code. Why not just skip the check if agent is enabled or not? It won't crash or anything, just leave an empty list.

ping @Thulium-Drake

[Thulium-Drake]

Perhaps, though I'm not sure about the performance/running time hit if you 'just' ask for a host's interface addresses on a larger cluster. :-)

In my case, I don't use this functionality at all (I use LXC on my home system almost exclusively), I mostly want a list of hostnames and resolve them using DNS.

But, if the complexity isn't worth it (and it might not be), I'm all for simpler code

[felixfontein]

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

[github-actions]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

[planeturban]

Perhaps, though I'm not sure about the performance/running time hit if you 'just' ask for a host's interface addresses on a larger cluster. :-)

I'll spin up ~100 vms and test. :)

In my case, I don't use this functionality at all (I use LXC on my home system almost exclusively), I mostly want a list of hostnames and resolve them using DNS.

But, if the complexity isn't worth it (and it might not be), I'm all for simpler code

I'll have a look at it this summer and make a new PR if there are none to little impact.