Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation of srv entries #5167 #5191

Closed

Conversation

martin-schlossarek
Copy link

SUMMARY

Fixes #5167

This PR removes the splicing of the record entry which resulted in malformed api calls. record must be the name of the subdomain or "@"

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloudflare_dns

ADDITIONAL INFORMATION

See: #5167 (comment)

This commit removes the splicing of the record entry which resulted in malformed api calls. record must be the name of the subdomain or "@"
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module net_tools new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Aug 25, 2022
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-4 labels Aug 26, 2022
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Sep 3, 2022
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending discussion in #5167.

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Sep 3, 2022
@felixfontein
Copy link
Collaborator

Please note that in #5461 the collection repository was restructured to remove the directory tree in plugins/modules/, and the corresponding tree in tests/unit/plugins/modules/. Your PR modifies files in this directory structure, and unfortunately now has some conflicts, potentially because of this. Please rebase with the current main branch to remove the conflicts.

@ansibullbot ansibullbot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Nov 3, 2022
@martin-schlossarek
Copy link
Author

Sorry, I didn't have time to look at the problem further. In the meantime my use case to be able to set SRV entries has also become obsolete.

I withdraw the pull request, if that's ok?

Nevertheless, I think it should be mentioned in the documentation that SRV entries must always have a FQDN specified. For other entries this is not the case.

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Docs Build 📝

This PR is closed and any previously published docsite has been unpublished.

@felixfontein
Copy link
Collaborator

Nevertheless, I think it should be mentioned in the documentation that SRV entries must always have a FQDN specified. For other entries this is not the case.

Do you want to create a PR for that? :)

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR net_tools new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflare_dns: unable to add SRV records using example from docs
3 participants