-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix creation of srv entries #5167 #5191
Fix creation of srv entries #5167 #5191
Conversation
This commit removes the splicing of the record entry which resulted in malformed api calls. record must be the name of the subdomain or "@"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending discussion in #5167.
Please note that in #5461 the collection repository was restructured to remove the directory tree in plugins/modules/, and the corresponding tree in tests/unit/plugins/modules/. Your PR modifies files in this directory structure, and unfortunately now has some conflicts, potentially because of this. Please rebase with the current |
Sorry, I didn't have time to look at the problem further. In the meantime my use case to be able to set SRV entries has also become obsolete. I withdraw the pull request, if that's ok? Nevertheless, I think it should be mentioned in the documentation that SRV entries must always have a FQDN specified. For other entries this is not the case. |
Docs Build 📝This PR is closed and any previously published docsite has been unpublished. |
Do you want to create a PR for that? :) |
SUMMARY
Fixes #5167
This PR removes the splicing of the record entry which resulted in malformed api calls. record must be the name of the subdomain or "@"
ISSUE TYPE
COMPONENT NAME
cloudflare_dns
ADDITIONAL INFORMATION
See: #5167 (comment)