Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple modules: removed unused imports #5240

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Sep 5, 2022

SUMMARY

Removed many imports that are not used by their code.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/cloud/alicloud/ali_instance.py
plugins/modules/cloud/alicloud/ali_instance_info.py
plugins/modules/cloud/misc/proxmox.py
plugins/modules/cloud/misc/proxmox_domain_info.py
plugins/modules/cloud/misc/proxmox_group_info.py
plugins/modules/cloud/misc/proxmox_kvm.py
plugins/modules/cloud/misc/proxmox_nic.py
plugins/modules/cloud/misc/proxmox_snap.py
plugins/modules/cloud/misc/proxmox_storage_info.py
plugins/modules/cloud/misc/proxmox_tasks_info.py
plugins/modules/cloud/misc/proxmox_template.py
plugins/modules/cloud/misc/proxmox_user_info.py
plugins/modules/database/misc/redis.py
plugins/modules/monitoring/airbrake_deployment.py
plugins/modules/monitoring/datadog/datadog_downtime.py
plugins/modules/remote_management/imc/imc_rest.py
plugins/modules/remote_management/redfish/ilo_redfish_info.py
plugins/modules/system/sap_task_list_execute.py
plugins/modules/web_infrastructure/rundeck_job_executions_info.py
plugins/modules/web_infrastructure/rundeck_job_run.py

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-4 labels Sep 5, 2022
@ansibullbot ansibullbot added the module_utils module_utils label Sep 9, 2022
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein merged commit 775be1d into ansible-collections:main Sep 9, 2022
@patchback
Copy link

patchback bot commented Sep 9, 2022

Backport to stable-4: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 775be1d on top of patchback/backports/stable-4/775be1d3f3edb1b53049b625f2115f1b1f75179b/pr-5240

Backporting merged PR #5240 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.general.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-4/775be1d3f3edb1b53049b625f2115f1b1f75179b/pr-5240 upstream/stable-4
  4. Now, cherry-pick PR multiple modules: removed unused imports #5240 contents into that branch:
    $ git cherry-pick -x 775be1d3f3edb1b53049b625f2115f1b1f75179b
    If it'll yell at you with something like fatal: Commit 775be1d3f3edb1b53049b625f2115f1b1f75179b is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x 775be1d3f3edb1b53049b625f2115f1b1f75179b
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR multiple modules: removed unused imports #5240 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-4/775be1d3f3edb1b53049b625f2115f1b1f75179b/pr-5240
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 9, 2022
@patchback
Copy link

patchback bot commented Sep 9, 2022

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/775be1d3f3edb1b53049b625f2115f1b1f75179b/pr-5240

Backported as #5257

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 9, 2022
* multiple modules: removed unused imports

* fixed ali_instance(_info) import check

* add changelog fragment

* Update changelogs/fragments/5240-unused-imports.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 775be1d)
felixfontein pushed a commit that referenced this pull request Sep 9, 2022
* multiple modules: removed unused imports

* fixed ali_instance(_info) import check

* add changelog fragment

* Update changelogs/fragments/5240-unused-imports.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 775be1d)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution :)

@russoz russoz deleted the unused-imports branch September 10, 2022 00:27
This was referenced Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants