proxmox inventory, remove redundant and simplify code #5437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we already have a templar from base class loop reuses code instead of X copies of it
ansibullbot
added
bug
bcoca
changed the title
felixfontein
added
check-before-release
felixfontein
approved these changes
Oct 29, 2022
felixfontein
removed
the
check-before-release
|
@bcoca thanks for improving this! |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
rekup
pushed a commit
to rekup/community.general
that referenced
this pull request
Nov 3, 2022
…tions#5437) * remove redundant and simplify code we already have a templar from base class loop reuses code instead of X copies of it * whitey * no need to import templar again * Add changelog fragment. Co-authored-by: Felix Fontein <felix@fontein.de>
russoz
pushed a commit
to russoz-ansible/community.general
that referenced
this pull request
Nov 5, 2022
…tions#5437) * remove redundant and simplify code we already have a templar from base class loop reuses code instead of X copies of it * whitey * no need to import templar again * Add changelog fragment. Co-authored-by: Felix Fontein <felix@fontein.de>
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
…tions#5437) * remove redundant and simplify code we already have a templar from base class loop reuses code instead of X copies of it * whitey * no need to import templar again * Add changelog fragment. Co-authored-by: Felix Fontein <felix@fontein.de>
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
…tions#5437) * remove redundant and simplify code we already have a templar from base class loop reuses code instead of X copies of it * whitey * no need to import templar again * Add changelog fragment. Co-authored-by: Felix Fontein <felix@fontein.de>
1 task
1 task
1 task
1 task
ghost
mentioned this pull request
1 task
1 task
1 task
1 task
1 task
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we already have a templar from base class
loop reuses code instead of X copies of it
ISSUE TYPE
COMPONENT NAME
inventory/proxmox