lxc_container: fix lxc argument when executing lxc command #5659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
cloudnull
approved these changes
Dec 5, 2022
|
shipit! |
felixfontein
reviewed
Dec 5, 2022
There was a problem hiding this comment.
Thanks for your contribution! Can you please add a changelog fragment? Thanks.
felixfontein
added
check-before-release
cloudnull
approved these changes
Dec 12, 2022
lxc_container fails when executing the lxc command (e.g. when creating
a new container) because PR#5358 broke the module argument
parsing. The resulting argument dict contained only the module argument name
and the argument flag but not the value. E.g.
```
- lxc_container:
template: debian
```
would result in lxc command arguments `lxc template --template` instead of
`lxc --template debian`.
Fixes: 6f88426 ("lxc_container: minor refactor (ansible-collections#5358)")
Fixes ansible-collections#5578
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
lynxis
force-pushed
the
fix-lxc-container
branch
from
c41dce0
to
f6f8ce0
Compare
Done. |
felixfontein
removed
the
check-before-release
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5697 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 17, 2022
lxc_container fails when executing the lxc command (e.g. when creating
a new container) because PR#5358 broke the module argument
parsing. The resulting argument dict contained only the module argument name
and the argument flag but not the value. E.g.
```
- lxc_container:
template: debian
```
would result in lxc command arguments `lxc template --template` instead of
`lxc --template debian`.
Fixes: 6f88426 ("lxc_container: minor refactor (#5358)")
Fixes #5578
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
(cherry picked from commit af53271)
|
@lynxis thanks for fixing this! |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5698 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 17, 2022
lxc_container fails when executing the lxc command (e.g. when creating
a new container) because PR#5358 broke the module argument
parsing. The resulting argument dict contained only the module argument name
and the argument flag but not the value. E.g.
```
- lxc_container:
template: debian
```
would result in lxc command arguments `lxc template --template` instead of
`lxc --template debian`.
Fixes: 6f88426 ("lxc_container: minor refactor (#5358)")
Fixes #5578
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
(cherry picked from commit af53271)
felixfontein
pushed a commit
that referenced
this pull request
Dec 17, 2022
…t when executing lxc command (#5697) lxc_container: fix lxc argument when executing lxc command (#5659) lxc_container fails when executing the lxc command (e.g. when creating a new container) because PR#5358 broke the module argument parsing. The resulting argument dict contained only the module argument name and the argument flag but not the value. E.g. ``` - lxc_container: template: debian ``` would result in lxc command arguments `lxc template --template` instead of `lxc --template debian`. Fixes: 6f88426 ("lxc_container: minor refactor (#5358)") Fixes #5578 Signed-off-by: Alexander Couzens <lynxis@fe80.eu> Signed-off-by: Alexander Couzens <lynxis@fe80.eu> (cherry picked from commit af53271) Co-authored-by: Alexander Couzens <lynxis@fe80.eu>
felixfontein
pushed a commit
that referenced
this pull request
Dec 17, 2022
…t when executing lxc command (#5698) lxc_container: fix lxc argument when executing lxc command (#5659) lxc_container fails when executing the lxc command (e.g. when creating a new container) because PR#5358 broke the module argument parsing. The resulting argument dict contained only the module argument name and the argument flag but not the value. E.g. ``` - lxc_container: template: debian ``` would result in lxc command arguments `lxc template --template` instead of `lxc --template debian`. Fixes: 6f88426 ("lxc_container: minor refactor (#5358)") Fixes #5578 Signed-off-by: Alexander Couzens <lynxis@fe80.eu> Signed-off-by: Alexander Couzens <lynxis@fe80.eu> (cherry picked from commit af53271) Co-authored-by: Alexander Couzens <lynxis@fe80.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
lxc_container fails when executing the lxc command (e.g. when creating a new container) because PR #5358 broke the module argument parsing. The resulting argument dict contained only the module argument name and the argument flag but not the value. E.g.
would result in the lxc command:
lxc template --template(current result)lxc --template debian(while this is the correct line)Fixes: 6f88426 ("lxc_container: minor refactor (#5358)")
Fixes #5578
CC: @russoz
ISSUE TYPE
COMPONENT NAME
lxc_container
ADDITIONAL INFORMATION
To reproduce the issue create a container which doesn't exist before:
will execute
/usr/bin/lxc-create --name some --quiet template --template backing_store --bdev -- --dist debian --release bullseye --arch amd64correct would be
/usr/bin/lxc-create --name some --quiet --template template --bdev dir -- --dist debian --release bullseye --arch amd64