Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5863/95b8afde backport][stable-6] providerType should be defaulted for keycloak_user_federation mappers #6079

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Feb 25, 2023

This is a backport of PR #5863 as merged into main (95b8afd).

SUMMARY

So called "mappers" which are special subcomponents of keycloak user federations (used to manage how ldap groups/users are mapped to keycloak groups/users) have the following json structure:

{
  "name": "...",
  "providerId": "...",
  "providerType": "...",
  "config": {
      [...]
  }
}

From this fields the one called providerType has nearly always the value org.keycloak.storage.ldap.mappers.LDAPStorageMapper, according to current docu it is actually the only supported value here (which is a bit weird, more on this in the additional section), so it would make sense to make it a default.

ISSUE TYPE

plugins/modules/keycloak_user_federation.py

ADDITIONAL INFORMATION

Besides proposing to set a default for providerType I also removed the part of its docu which says the new default value is the only supported one. I would argue it is confusing and from the ansible perspective also not true as the module does nothing special with this value or even the whole mapper subdict except for passing it upstream as is and comparing values key by key. It might be still true for the upstream API but even that can possibly change.

…#5863)

* feat(modules/keycloak_user_federation): mapper ...

... provider type should have a default value

* add changelog fragment

---------

Co-authored-by: Mirko Wilhelmi <Mirko.Wilhelmi@sma.de>
(cherry picked from commit 95b8afd)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport feature This issue/PR relates to a feature request identity module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Feb 25, 2023
@felixfontein felixfontein merged commit 79d15d5 into stable-6 Feb 25, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-6/95b8afdea3dd76a045ef00e86fbeb64bc8279c10/pr-5863 branch February 25, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request identity module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants