Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5143: xfs_quota fails to initialize new project quotas #6387

Merged

Conversation

cfiehe
Copy link
Contributor

@cfiehe cfiehe commented Apr 20, 2023

SUMMARY

This fix ensures that in case of a project quota, the corresponding project gets initialized, if required.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

xfs_quota

ADDITIONAL INFORMATION

This is an attempt to re-submit and improve #5144, in order to get this issue finally fixed.

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 20, 2023
@cfiehe cfiehe force-pushed the fix_xfs_quota_project_init branch 3 times, most recently from 24165f8 to 4ee1ced Compare April 20, 2023 19:36
@ansibullbot ansibullbot added integration tests/integration tests tests labels Apr 20, 2023
@cfiehe cfiehe force-pushed the fix_xfs_quota_project_init branch from 4ee1ced to 54bfbd8 Compare April 20, 2023 19:39
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Apr 20, 2023
@cfiehe cfiehe force-pushed the fix_xfs_quota_project_init branch from 54bfbd8 to 8137256 Compare April 20, 2023 20:01
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the underlying tools so I cannot judge whether the change is correct (in the sense that it calls the tool with the correct options to obtain its goal), but it formally looks OK to me.

tests/integration/targets/xfs_quota/tasks/pquota.yml Outdated Show resolved Hide resolved
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Apr 23, 2023
@cfiehe cfiehe force-pushed the fix_xfs_quota_project_init branch 2 times, most recently from 20eb46f to a4cb927 Compare April 23, 2023 20:41
…roject gets initialized, if required.

Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
@cfiehe cfiehe force-pushed the fix_xfs_quota_project_init branch from a4cb927 to 924d63c Compare April 30, 2023 20:08
@felixfontein
Copy link
Collaborator

Will merge if nobody objects by the end of this week.

@felixfontein felixfontein merged commit 9c11230 into ansible-collections:main May 6, 2023
@patchback
Copy link

patchback bot commented May 6, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/9c11230824c78f7547c1b6457d7f9722c0d7cf46/pr-6387

Backported as #6495

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 6, 2023
patchback bot pushed a commit that referenced this pull request May 6, 2023
This fix ensures that in case of a project quota, the corresponding project gets initialized, if required.

Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
Co-authored-by: Christoph Fiehe <c.fiehe@eurodata.de>
(cherry picked from commit 9c11230)
@felixfontein
Copy link
Collaborator

@cfiehe thanks for your contribution!

felixfontein pushed a commit that referenced this pull request May 6, 2023
…o initialize new project quotas (#6495)

Fixes #5143: xfs_quota fails to initialize new project quotas (#6387)

This fix ensures that in case of a project quota, the corresponding project gets initialized, if required.

Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
Co-authored-by: Christoph Fiehe <c.fiehe@eurodata.de>
(cherry picked from commit 9c11230)

Co-authored-by: cfiehe <cfiehe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants