Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for distutils.version being removed in Python 3.12 #267

Merged
merged 2 commits into from
Dec 23, 2021

Conversation

Andersson007
Copy link
Collaborator

@Andersson007 Andersson007 commented Dec 23, 2021

SUMMARY

Prepare for distutils.version being removed in Python 3.12

Relates to ansible-collections/overview#45 (comment)

ISSUE TYPE
  • Bugfix Pull Request

@Andersson007 Andersson007 changed the title Prepare for distutils.version being removed in Python 2.12 [WIP] Prepare for distutils.version being removed in Python 2.12 Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #267 (5a91096) into main (038a0b0) will increase coverage by 0.49%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   78.37%   78.86%   +0.49%     
==========================================
  Files          24       26       +2     
  Lines        2118     2139      +21     
  Branches      495      495              
==========================================
+ Hits         1660     1687      +27     
+ Misses        299      297       -2     
+ Partials      159      155       -4     
Impacted Files Coverage Δ
plugins/module_utils/version.py 75.00% <75.00%> (ø)
...odule_utils/implementations/mariadb/replication.py 100.00% <100.00%> (ø)
...ugins/module_utils/implementations/mariadb/role.py 100.00% <100.00%> (ø)
...ugins/module_utils/implementations/mariadb/user.py 100.00% <100.00%> (+22.22%) ⬆️
.../module_utils/implementations/mysql/replication.py 100.00% <100.00%> (ø)
plugins/module_utils/implementations/mysql/role.py 100.00% <100.00%> (ø)
plugins/module_utils/implementations/mysql/user.py 100.00% <100.00%> (ø)
plugins/modules/mysql_replication.py 68.37% <100.00%> (ø)
plugins/module_utils/mysql.py 71.08% <0.00%> (-12.05%) ⬇️
plugins/modules/mysql_query.py 86.58% <0.00%> (-2.44%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038a0b0...5a91096. Read the comment docs.

@Andersson007 Andersson007 changed the title [WIP] Prepare for distutils.version being removed in Python 2.12 [WIP] Prepare for distutils.version being removed in Python 3.12 Dec 23, 2021
@Andersson007 Andersson007 changed the title [WIP] Prepare for distutils.version being removed in Python 3.12 Prepare for distutils.version being removed in Python 3.12 Dec 23, 2021
plugins/module_utils/version.py Outdated Show resolved Hide resolved
Co-authored-by: Felix Fontein <felix@fontein.de>
@Andersson007 Andersson007 merged commit d9e12b8 into ansible-collections:main Dec 23, 2021
@Andersson007
Copy link
Collaborator Author

@felixfontein thanks for reviewing!

@felixfontein
Copy link
Collaborator

Please consider creating a follow-up PR based on ansible-collections/community.general#3984.

@Andersson007
Copy link
Collaborator Author

@felixfontein yep, will do, thanks!

Andersson007 added a commit to Andersson007/community.mysql that referenced this pull request Jan 17, 2022
…ollections#267)

* Prepare for distutils.version being removed in Python 3.12

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit d9e12b8)
Andersson007 added a commit to Andersson007/community.mysql that referenced this pull request Jan 17, 2022
…ollections#267)

* Prepare for distutils.version being removed in Python 3.12

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit d9e12b8)
Andersson007 added a commit that referenced this pull request Jan 18, 2022
* Prepare for distutils.version being removed in Python 3.12 (#267)

* Prepare for distutils.version being removed in Python 3.12

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit d9e12b8)

* Use vendored version of distutils.version (#269)

* Use vendored version of distutils.version

* Correct fragment

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 9c575b4)
Andersson007 added a commit that referenced this pull request Jan 18, 2022
* Prepare for distutils.version being removed in Python 3.12 (#267)

* Prepare for distutils.version being removed in Python 3.12

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit d9e12b8)

* Use vendored version of distutils.version (#269)

* Use vendored version of distutils.version

* Correct fragment

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 9c575b4)

* Add ignore-2.13.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants