Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #558/8ac19005 backport][stable-4] Fix gather_network_resources documentation for exos_facts #562

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Sep 13, 2023

This is a backport of PR #558 as merged into main (8ac1900).

SUMMARY

I stumbled upon some errors in the exos_facts documentation. gather_network_resources had typos in the exaples.
Also I improved the parameter description for gather_network_resources, because not all valid subsets that are defined in the module have been listed in the docs.
Not much, but might help some users.

Also I had the same problem like described in Issue #460 and took a look at it.
I don't currently have time to implement the gather_network_resources param for network_cli, but I added a note with a fix/workaround and a reference to the issue.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

exos_facts

ADDITIONAL INFORMATION

* Fix gather_network_resources documentation for exos_facts

* Added Note for gather_network_resources support

* sanity error fixes suggested by @Andersson007

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

---------

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit 8ac1900)
@Andersson007 Andersson007 reopened this Sep 13, 2023
@Andersson007 Andersson007 reopened this Sep 13, 2023
@Andersson007 Andersson007 merged commit af88817 into stable-4 Sep 13, 2023
50 checks passed
@Andersson007 Andersson007 deleted the patchback/backports/stable-4/8ac190054bd8f0351942628360f9e4720949c18a/pr-558 branch September 13, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants