Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql_query, postgresql_script: let psycopg2 do the list -> pg array conversion #412

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

betanummeric
Copy link
Member

fixes #411

This PR removes the logic which converts a query argument from a python list to a postgres array, because psycopg2 can do this better.

This changes the module arguments to SQL translation, so I'm not sure if this should be categorized as just a bugfix or a major change.

@betanummeric betanummeric force-pushed the fix-query-argument-array-conversion branch from 70c6b11 to 089d434 Compare February 10, 2023 11:16
@Andersson007
Copy link
Collaborator

@betanummeric if it changes the existing user interface anyhow (like values, choices, return values, etc.) / can lead to playbooks that worked won't work anymore after upgrade to a version containing the proposed change - it'd be a major change

@betanummeric
Copy link
Member Author

uhh, this PR is quite old already. But I think it is still justified.
The change size categorization mostly depends on whether we call the existing behavior a bug or a feature. It it like that for quite a while now, so it's probably a feature now -> major change. :/
I guess the PR is in draft only because it needs some testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postgresql_query, postgresql_script: array argument conversion
3 participants