Prepare for distutils.version being removed in Python 3.12 #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distutils has been deprecafed and will be removed from Python's stdlib in Python 3.12 (see https://python.org/dev/peps/pep-0632). This PR replaces the use of distutils.version.LooseVersion and distutils.version.StrictVersion with LooseVersion from the vendored copy of distutils.version included with ansible-core 2.12 (ansible/ansible#74644) if available, and falls back to distutils.version for ansible-core 2.11 and before. Since ansible-core 2.11 and earlier do not support Python 3.12 (since they use LooseVersion itself in various places), this incomplete fix should be OK for now. Also, the way this PR works (by adding a new module_utils version that abstracts away where LooseVersion comes from), it is easy to also fix this for ansible-core 2.11 and earlier later on. Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Andersson007
approved these changes
Dec 23, 2021
felixfontein
approved these changes
Dec 23, 2021
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
|
recheck |
|
recheck |
|
recheck |
|
@goneri Do you know why the last 4 CI jobs keep failing? I don't really understand this: |
Thx @felixfontein, it looks like it did! We still have some checks that fail, but I think this is a CI issue and has nothing to do with this PR. |
|
recheck |
|
recheck |
|
@mariolenz I keep an eye on the CI jobs. For the record, you can ignore the softwarefactory jobs for now. It's still experimental at this stage. |
|
hum, looks like there is several problems at the same time :-(. I will take a look when I'm back from PTO. |
|
recheck |
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
FYI: I've added the the Enjoy your PTO! |
|
Please consider creating a follow-up PR based on ansible-collections/community.general#3984. |
This was referenced Jan 9, 2022
This was referenced May 4, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 4, 2022
Prepare for distutils.version being removed in Python 3.12 SUMMARY This is a follow-up PR to #1165 and replaces the use of distutils.version.StrictVersion with ansible.module_utils.compat.version.StrictVersion. ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/module_utils/version.py plugins/module_utils/vmware.py ADDITIONAL INFORMATION distutils has been deprecated and will be removed from Python's stdlib in Python 3.12 (see PEP 632). Also, see here and the following comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
distutils has been deprecafed and will be removed from
Python's stdlib in Python 3.12 (see https://python.org/dev/peps/pep-0632).
This PR replaces the use of distutils.version.LooseVersion and distutils.version.StrictVersion
with LooseVersion from the vendored copy of distutils.version
included with ansible-core 2.12 (ansible/ansible#74644) if available,
and falls back to distutils.version for ansible-core 2.11 and before.
Since ansible-core 2.11 and earlier do not support Python 3.12 (since
they use LooseVersion itself in various places), this incomplete fix
should be OK for now. Also, the way this PR works (by adding a new
module_utils version that abstracts away where LooseVersion comes from),
it is easy to also fix this for ansible-core 2.11 and earlier later on.
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/disutils.version.yml
plugins/module_utils/version.py
plugins/modules/vmware_category.py
plugins/modules/vmware_vc_infraprofile_info.py