Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distutils is deprecated from Python's standard library, to be removed in Python 2.12 #585

Closed
rockaut opened this issue Dec 23, 2021 · 7 comments · Fixed by #597 or #603
Closed

distutils is deprecated from Python's standard library, to be removed in Python 2.12 #585

rockaut opened this issue Dec 23, 2021 · 7 comments · Fixed by #597 or #603

Comments

@rockaut
Copy link
Contributor

rockaut commented Dec 23, 2021

SUMMARY

We need to check if we use this

ansible-collections/overview#45 (comment)

ISSUE TYPE
  • Bug Report
@rockaut
Copy link
Contributor Author

rockaut commented Dec 28, 2021

I fear that will get a PITA. There are some ways to replace it easily but only for python 3. I haven't found anything for python 2 yet.

Could somebody please have a look at: ansible-collections/community.general#3936

Do I read it correctly, that we may use the Ansible builtin class which falls back to distutils for older releases if not found. We should be somewhat save then because may only fail in some unsupported cases?

I commented a question there but as I read it it will be only in the community.general collection not in the core package. This is not great.

@D3DeFi
Copy link
Contributor

D3DeFi commented Dec 28, 2021

I think that we don't have to worry about Py2.12 at all :) They had a type there. distutils will be deprecated only for Py3.12

@rockaut
Copy link
Contributor Author

rockaut commented Dec 28, 2021

I work on this currently (also on #596). I have an idea where we don't have dependencies at all.

@D3DeFi
Copy link
Contributor

D3DeFi commented Dec 28, 2021

Also the fixes proposed to you there - e.g. ansible-collections/community.postgresql#178 looks as a good solution

@rockaut
Copy link
Contributor Author

rockaut commented Dec 28, 2021

Good find. I will implement this.

D3DeFi pushed a commit that referenced this issue Dec 28, 2021
* implement distutils workaround

fixes #585
fixes #596

* fix sanity checks

* add changelogs
@felixfontein
Copy link
Contributor

Please consider creating a follow-up PR based on ansible-collections/community.general#3984.

@rockaut
Copy link
Contributor Author

rockaut commented Jan 7, 2022

Thanks @felixfontein will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants