Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests cannot succeed on local setup #245

Closed
jooola opened this issue Jul 3, 2023 · 2 comments
Closed

Integration tests cannot succeed on local setup #245

jooola opened this issue Jul 3, 2023 · 2 comments
Labels
bug Something isn't working stale

Comments

@jooola
Copy link
Collaborator

jooola commented Jul 3, 2023

SUMMARY

The hcloud_image_info integration test attempt to list a snapshot named always-there-snapshot, this snapshot is present in the Hetzner Cloud project used by the CI, but is not setup when running tests locally.

The hcloud_placement_group, hcloud_rdns and hcloud_server integration test attempt to attach an ssh key that is only present in the Hetzner Cloud project used by the CI.

Maybe a setup/teardown could be automated, or at least a setup.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

hcloud_image_info
hcloud_placement_group
hcloud_rdns

STEPS TO REPRODUCE
ansible-test integration -vv hcloud_image_info
ansible-test integration -vv hcloud_placement_group
ansible-test integration -vv hcloud_rdns
ansible-test integration -vv hcloud_server
EXPECTED RESULTS

The tests should pass locally as well as in the CI.

ACTUAL RESULTS

The tests fail because of the missing snapshot.

@jooola jooola changed the title hcloud_image_info integration tests cannot succeed on local setup Integration tests cannot succeed on local setup Jul 3, 2023
@jooola jooola added the bug Something isn't working label Jul 13, 2023
Copy link

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

@github-actions github-actions bot added the stale label Nov 14, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2023
@apricote
Copy link
Collaborator

I think this was fixed in #316 by explicitly creating a new snapshot before running the test: https://github.com/ansible-collections/hetzner.hcloud/blob/main/tests/integration/targets/image_info/tasks/prepare.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants