-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve hcloud library exceptions handling #243
Conversation
d081bdc
to
ab73bd6
Compare
e0cb009
to
34b7850
Compare
This is based onto #244, sorry for the messy commit history. Now that we handle the exception in a single place, we can collect some extra data and provide it to the users in the returned data. Here is an example of failing task when running with a verbose mode, we see the extra details in the
If the verbose mode is not enabled, we get the following:
I haven't figured how to clearly detail a failed action, for now I return the entire action object (we might need to convert it to a dict though). |
aa2ee69
to
3fa6e46
Compare
7609403
to
8deca37
Compare
SUMMARY
Related to #220
Properly handle the different type of exceptions raised by the hcloud library.
Improve the stack traces printed to the users.
ISSUE TYPE