Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dry run #245

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Add support for dry run #245

merged 2 commits into from
Oct 15, 2021

Commits on Sep 22, 2021

  1. Add support for dry run 

    Kubernetes server-side dry run will be used when the kubernetes client
version is >=18.20.0. For older versions of the client, the existing
client side speculative change implementation will be used.

The effect of this change should be mostly transparent to the end user
and is reflected in the fact the tests have not changed but should still
pass. With this change, there are a few edge cases that will be
improved. One example of these edge cases is to use check mode on an
existing Service resource. With dry run this will correctly report no
changes, while the older client side implementation will erroneously
report changes to the port spec.
    @gravesm
    gravesm committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    20cc18d View commit details
    Browse the repository at this point in the history

  2. Add changelog fragment

    @gravesm
    gravesm committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    31651a7 View commit details
    Browse the repository at this point in the history