Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module_defaults by removing routing hack #372

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Fix module_defaults by removing routing hack #372

merged 1 commit into from
Feb 9, 2022

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Feb 8, 2022 •
edited
Loading

SUMMARY

Fixes #202
Fixes ansible/ansible#76687

As mentioned here, I'm not sure what the redirection was originally solving, but this would be the ideal solution for module_defaults.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/347-routing.yml
meta/runtime.yml

@Akasurde Akasurde mentioned this pull request Feb 8, 2022
Closed
@softwarefactory-project-zuul
Copy link

Build succeeded.

@Akasurde
Copy link
Member Author

Akasurde commented Feb 9, 2022

mergeit

@Akasurde
Copy link
Member Author

Akasurde commented Feb 9, 2022

gate

@Akasurde
Copy link
Member Author

Akasurde commented Feb 9, 2022 •
edited
Loading

@goneri Do you know why gate and mergeit not triggering the gate job? Thanks in advance

@goneri goneri added the mergeit label Feb 9, 2022
@goneri
Copy link
Member

goneri commented Feb 9, 2022

@goneri Do you know why gate and mergeit not triggering the gate job? Thanks in advance

You need to apply the mergeit label.

@Akasurde
Copy link
Member Author

Akasurde commented Feb 9, 2022

@goneri Do you know why gate and mergeit not triggering the gate job? Thanks in advance

You need to apply the mergeit label.

I added text command 🤦🏼

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 583de32 into ansible-collections:main Feb 9, 2022
@Akasurde Akasurde deleted the remove_routing_hack branch February 9, 2022 16:32
@erikgb
Copy link

erikgb commented Feb 17, 2022

Any chance to get this bugfix released ASAP? It is blocking us ATM.

@Akasurde
Copy link
Member Author

This fix is merged for release 2.3.0. We are expecting the release soon. cc @gravesm

@erikgb
Copy link

erikgb commented Mar 19, 2022

Ugh, did the 2.3.0 release just missed the ansible 5.5.0 release? 😓 Was that intentional?

@lucastheisen lucastheisen mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

module_defaults appears to merge all settings helm_repository inherits module_defaults from k8s_info
4 participants
@Akasurde @goneri @erikgb @s-hertel