Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm template add name and disable hook #405

Merged
merged 5 commits into from
Apr 29, 2022
Merged

Helm template add name and disable hook #405

merged 5 commits into from
Apr 29, 2022

Conversation

cvstebut
Copy link
Contributor

SUMMARY

This PR adds "disable_hook" and "name" (NAME of the release) as optional arguments to the helm_template module.
It contains the rest of my planned work towards #313.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/helm_template.py
changelogs/fragments/313-helm-template-add-support-for-name-and-disablehook.yml
tests/unit/modules/test_helm_template.py
integration/targets/helm/tasks/tests_chart.yml

ADDITIONAL INFORMATION

The PR contains unit tests and an integration test for the new parameters added in this and the previous PR.
I limited the execution of the integration test to the local test chart, because the testing of the "show_only" parameter requires a known chart structure. As I think I do not have to test the workings of "helm template ..." itself, I hope this is sufficient.

Please adjust / comment as necessary.

@softwarefactory-project-zuul
Copy link

Build failed.

@cvstebut
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

gravesm
gravesm reviewed Apr 22, 2022
View reviewed changes
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This looks good! Would you mind making one small change? Rename the name parameter to release_name and add name as an alias? This would keep it consistent with the helm module.

@gravesm gravesm linked an issue Apr 22, 2022 that may be closed by this pull request
Missing flags on template module #313
Closed
@softwarefactory-project-zuul
Copy link

Build succeeded.

@softwarefactory-project-zuul
Copy link

Build failed.

@softwarefactory-project-zuul
Copy link

Build failed.

@softwarefactory-project-zuul
Copy link

Build succeeded.

@cvstebut
Copy link
Contributor Author

Please have a look. The commits include the changes in the options (name -> release_name; add name as alias).
There were two options to choose from: the naming of the helm module, and the naming of "helm template. I originally chose the naming of helm template for which "release_name" has a different meaning (--release-name use release name in the output-dir path.).
Using an alias is a nice way to solve it :-)

gravesm
gravesm approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@gravesm gravesm force-pushed the helm_template_add_name_and_disable_hook branch from 8484a10 to 5a39770 Compare April 29, 2022 12:56
@softwarefactory-project-zuul
Copy link

Build succeeded.

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 95e2add into ansible-collections:main Apr 29, 2022
@Rattnik
Copy link

Rattnik commented Sep 12, 2022

Hi, guys.
When will you release merged PR [95e2add] which contain .Release.Name? We are looking forward this feature.

@brentmjohnson
Copy link

Hi, guys. When will you release merged PR [95e2add] which contain .Release.Name? We are looking forward this feature.

Came here with the same question🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravesm gravesm gravesm approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing flags on template module
4 participants
@cvstebut @Rattnik @brentmjohnson @gravesm