make name optional to delete all resources for the specified resource type #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
|
Could you split the k8s_log changes out into a separate PR? Unless I'm missing something, these changes seem entirely separate from the select_all changes. |
PR #528 for k8s_log changes |
|
recheck |
goneri
reviewed
Oct 17, 2022
goneri
approved these changes
Oct 17, 2022
gravesm
reviewed
Oct 17, 2022
|
recheck |
|
recheck |
Update new feature - support deletion of all resources using delete_all: true
abikouo
changed the title
abikouo
changed the title
gravesm
reviewed
Mar 22, 2023
Co-authored-by: Mike Graves <mgraves@redhat.com>
Co-authored-by: Mike Graves <mgraves@redhat.com>
Co-authored-by: Mike Graves <mgraves@redhat.com>
gravesm
approved these changes
Mar 23, 2023
raukadah
added a commit
to openstack-k8s-operators/ci-framework
that referenced
this pull request
Apr 18, 2024
ansible-collections/kubernetes.core#517 added delete_all: true to delete all the resources. It needs to be added in fix openshift-marketplace task files to make sure all pods are deleted otherwise fix_openshift_marketplace.yml taskfile does not work as expected. Signed-off-by: Chandan Kumar <raukadah@gmail.com>
1 task
raukadah
added a commit
to openstack-k8s-operators/ci-framework
that referenced
this pull request
Apr 18, 2024
ansible-collections/kubernetes.core#517 added delete_all: true to delete all the resources. It needs to be added in fix openshift-marketplace task files to make sure all pods are deleted otherwise fix_openshift_marketplace.yml taskfile does not work as expected. Note: It also adds wait_sleep attributes to make sure all pods are running. Signed-off-by: Chandan Kumar <raukadah@gmail.com>
raukadah
added a commit
to openstack-k8s-operators/ci-framework
that referenced
this pull request
Apr 18, 2024
ansible-collections/kubernetes.core#517 added delete_all: true to delete all the resources. It needs to be added in fix openshift-marketplace task files to make sure all pods are deleted otherwise fix_openshift_marketplace.yml taskfile does not work as expected. Note: It also adds wait_sleep attributes and drop wait condition to make sure all pods are running. Signed-off-by: Chandan Kumar <raukadah@gmail.com>
raukadah
added a commit
to openstack-k8s-operators/ci-framework
that referenced
this pull request
Apr 18, 2024
ansible-collections/kubernetes.core#517 added delete_all: true to delete all the resources. It needs to be added in fix openshift-marketplace task files to make sure all pods are deleted otherwise fix_openshift_marketplace.yml taskfile does not work as expected. Note: It also adds wait_sleep attributes and drop wait condition to make sure all pods are running. Signed-off-by: Chandan Kumar <raukadah@gmail.com>
raukadah
added a commit
to openstack-k8s-operators/ci-framework
that referenced
this pull request
Apr 19, 2024
ansible-collections/kubernetes.core#517 added delete_all: true to delete all the resources. It needs to be added in fix openshift-marketplace task files to make sure all pods are deleted otherwise fix_openshift_marketplace.yml taskfile does not work as expected. Note: It also adds wait_sleep attributes and drop wait condition to make sure all pods are running. Signed-off-by: Chandan Kumar <raukadah@gmail.com>
raukadah
added a commit
to openstack-k8s-operators/ci-framework
that referenced
this pull request
Apr 19, 2024
ansible-collections/kubernetes.core#517 added delete_all: true to delete all the resources. It needs to be added in fix openshift-marketplace task files to make sure all pods are deleted otherwise fix_openshift_marketplace.yml taskfile does not work as expected. Note: It moves to oc commands to be make sure all the pods are in running state. Signed-off-by: Chandan Kumar <raukadah@gmail.com>
raukadah
added a commit
to openstack-k8s-operators/ci-framework
that referenced
this pull request
Apr 19, 2024
ansible-collections/kubernetes.core#517 added delete_all: true to delete all the resources. It needs to be added in fix openshift-marketplace task files to make sure all pods are deleted otherwise fix_openshift_marketplace.yml taskfile does not work as expected. Note: It moves to oc commands to be make sure all the pods are in Running state. Signed-off-by: Chandan Kumar <raukadah@gmail.com>
openshift-merge-bot bot
pushed a commit
to openstack-k8s-operators/ci-framework
that referenced
this pull request
Apr 19, 2024
ansible-collections/kubernetes.core#517 added delete_all: true to delete all the resources. It needs to be added in fix openshift-marketplace task files to make sure all pods are deleted otherwise fix_openshift_marketplace.yml taskfile does not work as expected. Note: It moves to oc commands to be make sure all the pods are in Running state. Signed-off-by: Chandan Kumar <raukadah@gmail.com>
bshephar
pushed a commit
to bshephar/ci-framework
that referenced
this pull request
Apr 22, 2024
ansible-collections/kubernetes.core#517 added delete_all: true to delete all the resources. It needs to be added in fix openshift-marketplace task files to make sure all pods are deleted otherwise fix_openshift_marketplace.yml taskfile does not work as expected. Note: It moves to oc commands to be make sure all the pods are in Running state. Signed-off-by: Chandan Kumar <raukadah@gmail.com>
bshephar
pushed a commit
to bshephar/ci-framework
that referenced
this pull request
Apr 23, 2024
ansible-collections/kubernetes.core#517 added delete_all: true to delete all the resources. It needs to be added in fix openshift-marketplace task files to make sure all pods are deleted otherwise fix_openshift_marketplace.yml taskfile does not work as expected. Note: It moves to oc commands to be make sure all the pods are in Running state. Signed-off-by: Chandan Kumar <raukadah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
closes #504
k8s module should allow deleting all namespace resources for the specified resource type.
ISSUE TYPE
COMPONENT NAME
k8s
ADDITIONAL INFORMATION
Delete all Pods from namespace test