Fix collection module info quirk

[abadger]

SUMMARY

Fix the detection of collection module_utils

Before, when you imported an identifier from a module_util with the same
name as the Python module it belongs in, the CollectionModuleInfo class
would think that the identifier was a Python module and return the
source for the Python module when requested.  This change fixes the code
so that the class will throw an error in this case.

The lack of error was causing an issue when constructing AnsiballZs.
For instance:

    from ..module_utils.ismount import ismount

The former code would create the file:
    ansible_collections/ansible/posix/plugins/module_utils/ismount/ismount.py

Instead of:
    ansible_collections/ansible/posix/plugins/module_utils/ismount.py

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

• This also implements pkg_dir in the CollectionModuleInfo class. I'm not sure if there's more that needs to be done to make use of that.
• In a similar vein, the FIXMEs around collections in Ansiballz should be reviewed to see if any of them are also resolved by this change.
• Lastly.... As I wrote this I kept feeling like there was probably a better way to do this. It feels like there should be an API in pkg_utils or importlib/imp or something else that a python loader or python finder might implement that would do the same thing as my code. I couldn't find it, though, so maybe that's just something to keep in mind as a potential refactor when the collection loader is next worked on.

[abadger]

ci_complete

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 1 error:

test/integration/targets/collections/collection_root_user/ansible_collections/testns/testcoll/plugins/modules/test_quirk.py:16:0: relative-beyond-top-level: Attempted relative import beyond top-level package

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 1 error:

test/integration/targets/collections/collection_root_user/ansible_collections/testns/testcoll/plugins/module_utils/quirk.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 1 error:

test/integration/targets/collections/collection_root_user/ansible_collections/testns/testcoll/plugins/module_utils/quirk.py:0:0: missing: __metaclass__ = type

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/executor/module_common.py:691:5: E301: expected 1 blank line, found 0

click here for bot help

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 1 error:

test/integration/targets/collections/collection_root_user/ansible_collections/testns/testcoll/plugins/modules/test_quirk.py:16:0: relative-beyond-top-level: Attempted relative import beyond top-level package

click here for bot help

[gundalow]

@felixfontein Hi, I believe you tested this PR did it improve the situation for you? Was it an issue in mount, or something else?

@abadger What do you think the next steps are for this?

[felixfontein]

@gundalow I tested this PR just for another problem (which it didn't solve).

[abadger]

@gundalow nitzmahone said he Incorporated a better fix into his routing pr (@nitzmahone can you confirm?)

We can probably look at the routing pr to see if the tests i added here got added there as another way to confirm whether there's a fix in there

[abadger]

I see a test for this case in the routing PR so I think that it is fixed in a different way there.

[abadger]

The routing PR (with test for this issue) has now been merged. felixfontein confirms that xfs_quota is no longer broken. Closing this issue.