Expose playbooks off of projects #62

syncrou · 2017-01-20T21:52:06Z

Playbooks are only available from a project.
This PR exposes /playbooks as a collection from said project.

The Tower API returns playbooks as an Array vs a Hash from POST, PUT, PATCH(able) endpoints.
The parse_result_set method was modified to handle each case appropriately while not breaking the existing lazy Enumerator behavior.

https://www.pivotaltracker.com/story/show/137293767

Testing Notes

conn = AnsibleTowerClient::Connection.new(
  :username => "username",
  :password => "password",
  :base_url => "https://dev-ansible-tower3.test.com/api/v1",
  :verify_ssl => OpenSSL::SSL::VERIFY_NONE
)
proj = conn.api.projects.find <id>
proj.playbooks.first

conn = AnsibleTowerClient::Connection.new(
  :username => "username",
  :password => "password",
  :base_url => "https://dev-ansible-tower3.test.com/api/v1",
  :verify_ssl => OpenSSL::SSL::VERIFY_NONE
)
proj = conn.api.projects.find <id>
proj.playbooks.each { |x| puts x }

Playbooks are only available from a project I expose a playbooks as a collection from a project The Tower API returns playbooks as an Array, vs a Hash from POST, PUT, PATCH(able) endpoints The parse_result_set method was modified to handle each case https://www.pivotaltracker.com/story/show/137293767

syncrou · 2017-01-20T21:52:29Z

@miq-bot assign @bdunne

@miq-bot add_label enhancement

bdunne · 2017-01-20T22:43:27Z

lib/ansible_tower_client/collection.rb

+    def parse_result_set(body)
+      case body.class.name
+      when "Array" then
+        body.each { |result| @collection << result }


Can this be simplified to @collection = body?

Yes - it can.

No need to iterate over an array.

miq-bot · 2017-01-20T23:12:46Z

Checked commits syncrou/ansible_tower_client@13be055~...fd8c6cf with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0
3 files checked, 0 offenses detected
Everything looks good. ⭐

Added - Refactor `#endpoint` [(#64)](#64) - Expose playbooks off of projects [(#62)](#62) Changed - Allow for alternative resource paths [(#66)](#66) - Raise UnlicensedFeatureError when we receive HTTP 402 [(#65)](#65) Fixed - Adjusted project_spec to test on a Project [(#63)](#63)

miq-bot assigned bdunne Jan 20, 2017

miq-bot added the enhancement label Jan 20, 2017

Added specs around an endpoint returning an Array

8f6369a

syncrou force-pushed the expose_playbooks_off_of_projects branch from 04d335d to 8f6369a Compare January 20, 2017 22:30

bdunne reviewed Jan 20, 2017

View reviewed changes

Small refactor

fd8c6cf

No need to iterate over an array.

bdunne merged commit 1abb87e into ansible:master Jan 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose playbooks off of projects #62

Expose playbooks off of projects #62

syncrou commented Jan 20, 2017 •

edited

Loading

syncrou commented Jan 20, 2017

bdunne Jan 20, 2017

syncrou Jan 20, 2017

miq-bot commented Jan 20, 2017

Expose playbooks off of projects #62

Expose playbooks off of projects #62

Conversation

syncrou commented Jan 20, 2017 • edited Loading

syncrou commented Jan 20, 2017

bdunne Jan 20, 2017

Choose a reason for hiding this comment

syncrou Jan 20, 2017

Choose a reason for hiding this comment

miq-bot commented Jan 20, 2017

syncrou commented Jan 20, 2017 •

edited

Loading