All client errors should derive from AnsibleTowerClient::ClientError

[bdunne]

Fixes #70

[bdunne]

@syncrou @carbonin Please review

[miq-bot]

Checked commit bdunne@92c1814 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 1 offense detected

lib/ansible_tower_client/exception.rb

• ⚠️ - Line 2, Col 25 - Lint/InheritException - Inherit from RuntimeError instead of Exception.

[syncrou]

@bdunne - It looks good - any thoughts on the second request in #70 in regards to wrapping the behavior into a credentials_valid? method? Or modifying connection.api.verify_credentials

[bdunne]

@syncrou I think the second part was just an example

[gmcculloug]

@bdunne Does this require additional changes in the ManageIQ/manageiq repo to address existing Faraday rescues like: app/models/manageiq/providers/ansible_tower/automation_manager/job.rb#L37

[bdunne]

@gmcculloug Yes, it does. I'll make a followup PR to ManageIQ.