Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ownerRef to null for SA, Role and RoleBinding to avoid conflicts #144

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Set ownerRef to null for SA, Role and RoleBinding to avoid conflicts #144

wants to merge 1 commit into from

Conversation

rooftopcellist
Copy link
Member

Set ownerRef to null for SA, Role and RoleBinding to avoid conflicts

  • Without this, if an AnsibleJob is deleted while another is running,
    it's service account, role and rolebinding will be cascade deleted,
    making the running job fail.

dsavineau
dsavineau approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@dsavineau dsavineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
However, since we doing the same task in all roles then I think we should create a common role for this so each roles can include that task (and avoid duplication)

@rooftopcellist rooftopcellist marked this pull request as draft October 31, 2023 20:41
@rooftopcellist
Copy link
Member Author

In case we revisit this to set the ownerRef to be the operator deployment:

@rooftopcellist rooftopcellist force-pushed the unset-ownerrefs branch 3 times, most recently from 875c074 to 71939c2 Compare November 9, 2023 03:21
@rooftopcellist rooftopcellist marked this pull request as ready for review November 9, 2023 03:22
@rooftopcellist
Set ownerRef to null for SA, Role and RoleBinding to avoid conflicts
7ec1c12 
 - Without this, if an AnsibleJob is deleted while another is running,
   it's service account, role and rolebinding will be cascade deleted,
   making the running job fail.

Signed-off-by: Christian M. Adams <chadams@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsavineau dsavineau dsavineau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rooftopcellist @dsavineau