Fix/issue 104 - Points snapshot generation #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected handling of optional named_selection for generate_points()
Modified unit tests for points generation
2 tasks
lboucin
reviewed
Aug 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 88.70% 88.75% +0.04%
==========================================
Files 11 11
Lines 2310 2320 +10
==========================================
+ Hits 2049 2059 +10
Misses 261 261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-ordered the arguments on generate_points() so it is the same as generate_snapshots() and named_selection is optional.
Added unit test for export of points and full model and named_selection.
Added unit test for export of snapshot on named_selection
Modified existing unit test and example for generate_points() to account for new argument ordering
resolves #104