Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support customize separator #15055

Merged
merged 6 commits into from
Feb 28, 2019
Merged

support customize separator #15055

merged 6 commits into from
Feb 28, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 26, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

close #9891

API Realization (Optional if not new feature)

<RangePicker separator="test" />

What's the effect? (Optional if not new feature)

Popup style will change with input & separator line.

Changelog description (Optional if not new feature)

  1. DatePicker support separator prop.
  2. DatePicker 支持 separator 属性。

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

readonly=""
tabindex="-1"
value=""
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

readonly=""
tabindex="-1"
value=""
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

@@ -122,6 +122,7 @@ The following APIs are shared by DatePicker, MonthPicker, RangePicker, WeekPicke
| format | to set the date format | string | "YYYY-MM-DD HH:mm:ss" |
| ranges | preseted ranges for quick selection | { \[range: string]: [moment](http://momentjs.com/)\[] } \| { \[range: string]: () => [moment](http://momentjs.com/)\[] } | - |
| renderExtraFooter | render extra footer in panel | () => React.ReactNode | - |
| separator | (Add in 3.14.0) set separator between inputs | string | '~' |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

版本信息加一列吧。#14818

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加的一列叫 Version | 版本以节约列宽度。

@netlify
Copy link

netlify bot commented Feb 26, 2019

Deploy preview for ant-design ready!

Built with commit 20d6749

https://deploy-preview-15055--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #15055 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #15055   +/-   ##
========================================
  Coverage    93.08%   93.08%           
========================================
  Files          247      247           
  Lines         6635     6635           
  Branches      1920     1920           
========================================
  Hits          6176     6176           
  Misses         458      458           
  Partials         1        1
Impacted Files Coverage Δ
components/date-picker/RangePicker.tsx 94.54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a16708...20d6749. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Feb 27, 2019

image

~ 的位置和之前的不太一样了。

@zombieJ
Copy link
Member Author

zombieJ commented Feb 27, 2019

~ 的位置和之前的不太一样了。

调了一下,再看看~

@zombieJ zombieJ merged commit 5ce7e71 into feature Feb 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the range-picker-sp branch February 28, 2019 08:11
@brdar
Copy link

brdar commented Mar 29, 2019

typescript prop does not work.

@ztplz
Copy link
Contributor

ztplz commented Mar 29, 2019

@Brlja More detail information?

@brdar
Copy link

brdar commented Mar 30, 2019

I get an error that property "separator" does not exist. Using the latest version. Twice checked.

@ztplz ztplz mentioned this pull request Mar 31, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants